feat: add AggregateCommits use case - #71
Merged
Merged
Conversation
sdomingobasora
added
type: feat
mikededo
reviewed
Dec 11, 2022
Comment on lines
+7
to
+9
| private int numCommits; | ||
| private int linesAdded; | ||
| private int linesRemoved; |
Contributor
There was a problem hiding this comment.
Should we use primitives or classes for numbers and so on?
Collaborator
Author
There was a problem hiding this comment.
Let's keep them as primitives as in the Commit we have primitive types for additions and deletions. Afterwards we can open an issue and homogenize criteria in all places of the code if we find it better.
mikededo
approved these changes
Dec 11, 2022
mikededo
added
status: deploy
mikededo
added
status: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This use case is very similar to #47.
The suggested changes for #47 by reviewers were applied here as well.