Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package io.pakland.mdas.githubstats.application;

import io.pakland.mdas.githubstats.domain.Commit;
import io.pakland.mdas.githubstats.domain.CommitAggregation;
import org.springframework.stereotype.Service;

import java.util.List;

@Service
public class AggregateCommits {

public AggregateCommits() {}

public CommitAggregation execute(List<Commit> commits) {
return CommitAggregation.aggregate(commits);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package io.pakland.mdas.githubstats.domain;

import java.util.List;

public class CommitAggregation {

private int numCommits;
private int linesAdded;
private int linesRemoved;
Comment on lines +7 to +9

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use primitives or classes for numbers and so on?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep them as primitives as in the Commit we have primitive types for additions and deletions. Afterwards we can open an issue and homogenize criteria in all places of the code if we find it better.


public static CommitAggregation aggregate(List<Commit> commits) {
CommitAggregation commitAggregation = new CommitAggregation();
commitAggregation.numCommits = (int) commits.stream().distinct().count();
commitAggregation.linesAdded = commits.stream().mapToInt(Commit::getAdditions).sum();
commitAggregation.linesRemoved = commits.stream().mapToInt(Commit::getDeletions).sum();
return commitAggregation;
}

public int getNumCommits() {
return numCommits;
}

public int getLinesAdded() {
return linesAdded;
}

public int getLinesRemoved() {
return linesRemoved;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
package io.pakland.mdas.githubstats.application;

import io.pakland.mdas.githubstats.domain.Commit;
import io.pakland.mdas.githubstats.domain.CommitAggregation;
import org.junit.jupiter.api.Test;

import java.util.ArrayList;
import java.util.List;
import java.util.Random;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class AggregateCommitsTest {

@Test
public void aggregatingCommits_shouldGiveValidNumCommits() {
List<Commit> commits = new ArrayList<>();

int numCommits = new Random().nextInt(10);

for (int i = 0; i < numCommits; i++) {
commits.add(mock(Commit.class));
}

CommitAggregation commitAggregation = CommitAggregation.aggregate(commits);
assertEquals(commitAggregation.getNumCommits(), numCommits);
}

@Test
public void aggregatingCommits_shouldGiveValidLinesAdded() {
List<Commit> commits = new ArrayList<>();

int totalLines = 0;

for (int i = 0; i < 10; i++) {
int numLines = new Random().nextInt(1000);
Commit commit = mock(Commit.class);
when(commit.getAdditions()).thenReturn(numLines);
commits.add(commit);
totalLines += numLines;
}

CommitAggregation commitAggregation = CommitAggregation.aggregate(commits);
assertEquals(commitAggregation.getLinesAdded(), totalLines);
}

@Test
public void aggregatingCommits_shouldGiveValidLinesRemoved() {
List<Commit> commits = new ArrayList<>();

int totalLines = 0;

for (int i = 0; i < 10; i++) {
int numLines = new Random().nextInt(1000);
Commit commit = mock(Commit.class);
when(commit.getDeletions()).thenReturn(numLines);
commits.add(commit);
totalLines += numLines;
}

CommitAggregation commitAggregation = CommitAggregation.aggregate(commits);
assertEquals(commitAggregation.getLinesRemoved(), totalLines);
}

}