go-llvm: select custom LLVM by orthogonal build tags - #3
Merged
Conversation
Author
|
Updated to the smaller static-link design requested in review:
Local validation passed for both |
Author
|
CI follow-up: removed the 51-minute per-PR LLVM source build. Automatic checks now run only the honest LLVM-independent source-format validation (current run: 6 seconds). Full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
byollvm, and LLVM 14-22 compatibility pathsllvm23) independent from link mode (dynamicllvmorstaticllvm)${SRCDIR}/llvmas the only payload path, supplied as an ignored symlink by the callerlibLLVMGoALLC.aaggregateDepends on goallc/llvm-project#2 for the static aggregate target.
Validation
go test -tags="llvm23 dynamicllvm" ./...go test -tags="llvm23 staticllvm" ./...