cmd: select custom LLVM through dist parameters - #2
Merged
Conversation
Author
|
Updated to move static aggregation into
Validation: standalone go-llvm dynamic/static tests passed; full Go three-stage |
Author
|
Follow-up after go-llvm PR #3 merged:
Validation: full three-stage builds passed in both dynamic and static modes while the removed environment variables were deliberately set to invalid values, confirming that only the command-line parameters are honored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-llvm-dir,-llvm-version, and-llvm-linktocmd/dist bootstrap/make.bash-llvm-dir, thenGOALLC_LLVM_DIR, then$GOROOT/llvm${SRCDIR}/llvmpath with an ignored symlinkllvm23,dynamicllvmorllvm23,staticllvmbuild tags without using ambientCGO_*variables or generated filesDepends on goallc/go-llvm#3 and, for static mode, goallc/llvm-project#2.
Validation
src/make.bash -a(default$GOROOT/llvm, LLVM 23, dynamic)src/make.bash -a -llvm-dir=$GOROOT/llvm -llvm-link=dynamic -llvm-version=23src/make.bash -a -llvm-dir=$GOROOT/llvm -llvm-link=static -llvm-version=23bin/go test cmd/distbin/go test -tags="llvm23 dynamicllvm" cmd/compile/internal/ssa cmd/objviewThe local Debug LLVM was built with the macOS 26 SDK while Go targets macOS 16, so the existing deployment-target linker warning remains.