Skip to content

GoObj: describe fixed alloca roots in statepoint deopts - #18

Merged
zhouguangyuan0718 merged 1 commit into
goallc:llvm23.1.masterfrom
zhouguangyuan0718:codex/alloca-statepoint-ptrmap-contract
Aug 1, 2026
Merged

GoObj: describe fixed alloca roots in statepoint deopts#18
zhouguangyuan0718 merged 1 commit into
goallc:llvm23.1.masterfrom
zhouguangyuan0718:codex/alloca-statepoint-ptrmap-contract

Conversation

@zhouguangyuan0718

@zhouguangyuan0718 zhouguangyuan0718 commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • remove the fixed-stack-home statepoint lowering added for pointer-containing allocas
  • preserve deopt location counts and constant values through StackMaps
  • define and strictly parse a self-describing 64-bit alloca pointer-map suffix in GoObj
  • synthesize Go locals pointer maps directly from the alloca frame location and bitmap
  • reject malformed, duplicate, overlapping, non-direct, or out-of-frame records

The memory slot remains authoritative across the call. No statepoint root spill, gc.relocate, or post-call write-back is required for these allocas.

Validation

  • rebuilt Debug llc, opt, llvm-ar, LLVM, and llvm-config for X86 and AArch64
  • paired GoALLC plugin suite: 45/45 passed
  • opt default O2, llc verify-machineinstrs, MIR frame-location checks, GoObj pointer-map checks
  • AArch64 wbZero/wbMove disassembly confirms no stale post-call store and no added root spill
  • runtime GC and stack-growth fixture passed

Paired producer and end-to-end tests: goallc/go#33.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Hello @zhouguangyuan0718 👋

Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.

  • All contributions to LLVM must follow our LLVM AI Tool Use Policy. In particular, if you used AI while working on this PR, remember to add a note to the PR description.
  • The LLVM Code-Review Policy and Practices document contains practical information about the PR process, including how patches are reviewed and accepted, and who can review a PR.
  • Our LLVM Developer Policy describes our expectations for code quality, commit summaries and contains notes on our CI system.

Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description.


Frequently asked questions

How do I add reviewers?

This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically.

You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using @ followed by their GitHub username.

What if there are no comments?

If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers.

Are any special GitHub settings required to contribute to LLVM?

We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details.


If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse.

Thank you,
The LLVM Community

@zhouguangyuan0718
zhouguangyuan0718 merged commit 8d73aa5 into goallc:llvm23.1.master Aug 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant