CodeGen: support plugin IR passes immediately before ISel - #88
CodeGen: support plugin IR passes immediately before ISel#88zhouguangyuan0718 wants to merge 4 commits into
Conversation
|
Hello @zhouguangyuan0718 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
Summary
TargetPassConfig::addPreISelPassso pass plugins can schedule legacy IR function passes after CodeGenPrepare and immediately before SelectionDAGinlineasm_brindirect-target CFG successors when BranchFolding removes empty or branch-only blocksalloca, typedbyval, andgoretstatepoint roots as frame-index rematerializations instead of ordinary spillsMotivation
GoALLC inserts statepoints after CodeGenPrepare, splits each statepoint continuation, and rebuilds fixed-frame memory addresses from the latest
gc.relocate. A goret or byval home is a caller-owned stack object: its address must follow stack growth semantics, but it must not become an ordinary local-pointer spill. Separately, a direct frame base may be present ingc-liveonly to rematerialize that address, so GoObj needs an independent bit describing whether the objects pointer-containing contents are live at the callsite.Validation
TestLLVM, with runtime kept native: passarchive/tarbuilt and tested with-gcflags=all=-enablellvm -llvmironlyanddefault<O2>: passencoding/json/jsontext; investigation continues in the Go PR