Chore: import golang golden overrides from cpp-jsonnet#845
Chore: import golang golden overrides from cpp-jsonnet#845johnbartholomew merged 2 commits intogoogle:masterfrom
Conversation
All the go-jsonnet golden output overrides should be kept here in the go-jsonnet repo. The older override mechanism (in which the cpp-jsonnet repo has golden files for Golang ending in .golang) will be removed.
|
The golend is go-jsonnet is not named as the golden in cpp-jsonnet, I suggest we keep it the same as cpp-jsonnet, then every *.jsonnet will have a *.jsonnet.golden |
|
Jrsonnet is fine with either naming, right now both c++ and golang tests pass (with some exceptions and overrides) The only thing I wish is that tests had some indications that they contain stacktrace in their name, similar to "error.*" tests in cpp-jsonnet, because stack traces are very different in jrsonnet/sjsonnet, and with some exceptions (golang's/cpp ugly float formatting) only they should be different between implementations |
|
Thanks for the comments and suggestions. I agree it would be good to make it easier for multiple implementations to share more of the test suite, but could we move this discussion to existing issue google/jsonnet#1235 instead? This specific PR is not going to fix the noted naming inconsistencies, as it only relates to the test_cmd tests, as run by the run_cmd_tests.sh script, which is used directly by both C++ jsonnet and Go jsonnet. |
All the go-jsonnet golden output overrides should be kept here in the go-jsonnet repo. The older override mechanism (in which the cpp-jsonnet repo has golden files for Golang ending in .golang) will be removed.