Skip to content

Comments

Chore: import golang golden overrides from cpp-jsonnet#845

Merged
johnbartholomew merged 2 commits intogoogle:masterfrom
johnbartholomew:use-local-test-overrides
Feb 13, 2026
Merged

Chore: import golang golden overrides from cpp-jsonnet#845
johnbartholomew merged 2 commits intogoogle:masterfrom
johnbartholomew:use-local-test-overrides

Conversation

@johnbartholomew
Copy link
Collaborator

All the go-jsonnet golden output overrides should be kept here in the go-jsonnet repo. The older override mechanism (in which the cpp-jsonnet repo has golden files for Golang ending in .golang) will be removed.

All the go-jsonnet golden output overrides should be kept here in
the go-jsonnet repo. The older override mechanism (in which the
cpp-jsonnet repo has golden files for Golang ending in .golang)
will be removed.
@coveralls
Copy link

coveralls commented Feb 9, 2026

Coverage Status

coverage: 44.295%. remained the same
when pulling 1dd6e89 on johnbartholomew:use-local-test-overrides
into 0d99c17 on google:master.

@He-Pin
Copy link

He-Pin commented Feb 11, 2026

The golend is go-jsonnet is not named as the golden in cpp-jsonnet,
in golang: *.jsonnet and *.golden
in cpp: *.jsonnet and *.jsonnet.golden

I suggest we keep it the same as cpp-jsonnet, then every *.jsonnet will have a *.jsonnet.golden
This will help jrsonnet and sjsonnet which sync test suite from upstream projects

@google google deleted a comment from johnny1494 Feb 13, 2026
@CertainLach
Copy link

CertainLach commented Feb 13, 2026

Jrsonnet is fine with either naming, right now both c++ and golang tests pass (with some exceptions and overrides)
https://github.com/CertainLach/jrsonnet/blob/master/tests/tests/cpp_test_suite.rs#L232-L242

The only thing I wish is that tests had some indications that they contain stacktrace in their name, similar to "error.*" tests in cpp-jsonnet, because stack traces are very different in jrsonnet/sjsonnet, and with some exceptions (golang's/cpp ugly float formatting) only they should be different between implementations

@johnbartholomew
Copy link
Collaborator Author

Thanks for the comments and suggestions. I agree it would be good to make it easier for multiple implementations to share more of the test suite, but could we move this discussion to existing issue google/jsonnet#1235 instead?

This specific PR is not going to fix the noted naming inconsistencies, as it only relates to the test_cmd tests, as run by the run_cmd_tests.sh script, which is used directly by both C++ jsonnet and Go jsonnet.

@johnbartholomew johnbartholomew merged commit 1dd6e89 into google:master Feb 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants