Repository navigation
test(version): cover jsonOutput when disabled; fix inverted guard test - #754
Merged
Merged
Conversation
Fixes #725 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 3h 6m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
`disableJsonOutput` existed only for the spec's beforeEach, and it skipped the state reset `enableJsonOutput` does, so tests could see each other's data. The beforeEach resets with `enableJsonOutput(false)` again, and one test drives every mutator and `printJsonOutput` on a fresh, never-enabled module. It covers all the disabled-mode guards, not just addChangelogData's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #725
Made with Cursor
This PR appears safe to merge.Summary
Adds
disableJsonOutput()and fixes the changelog test to check that disabled JSON output collects no data.Reviews (1) · Last reviewed commit: "test(version): cover jsonOutput when dis..." · Reviewed by Greptile