Repository navigation
docs(templates): link standing-pr.yml comments to published ci-setup URLs - #756
Merged
Merged
Conversation
…URLs Fixes #728 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Standing release PR: #730 · v0.42.1 queued (4 packages) · open 1h 24m · ✅ ready to merge Release Preview — v0.42.0 → v0.42.1
These changes will be added to the release PR (#730) when merged: Changelogmonorepo 0.42.0 → 0.42.1
After merge — predicted release
Updated automatically by ReleaseKit |
goosewobbler
pushed a commit
that referenced
this pull request
Oct 23, 2026
The note sat directly above the line #756 rewrites, so the two PRs conflicted. It now has its own paragraph after the guide link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
Merged
goosewobbler
added a commit
that referenced
this pull request
Oct 24, 2026
* docs(ci): warn that the Actions PR toggle also grants approvals Co-authored-by: Cursor <cursoragent@cursor.com> * docs(ci): environment protection requires environment secrets Co-authored-by: Cursor <cursoragent@cursor.com> * docs(ci): require the publish environment on immediate releases too Co-authored-by: Cursor <cursoragent@cursor.com> * docs(ci): cover retry-publish and refresh-after-release in the approval guidance The environment advice named publish-release and immediate-release, but the ci-setup workflow and the example also publish from retry-publish. The App token must also reach refresh-after-release, which can open the standing PR. The section is shorter, the copied example workflow links to it by URL, and the template comment no longer points at a path consumers don't have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ci): move the template's approval note below the guide link The note sat directly above the line #756 rewrites, so the two PRs conflicted. It now has its own paragraph after the guide link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ci): say once where the publish environment goes The publish-release comment already names immediate-release, so the matching note on immediate-release repeated it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ci): correct the workflow token approval guidance A branch-restricted environment rejects the publish jobs, since they run on pull_request with the ref refs/pull/N/merge. A GitHub App whose key is a repository secret can be minted by any workflow, so it doesn't close the approval gap. Code Owners review only covers paths in CODEOWNERS, so it needs a `*` rule. The section now sits under "Securing the standing PR", and the template, example and README link to it instead of restating it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ci): cover bypasses, stale approvals and CODEOWNERS gaps Code Owners review doesn't apply to bypass actors, and the release bot is one. A stale code-owner approval still counts after new commits unless it's dismissed, and a CODEOWNERS owner without write access is ignored. Drops the environment-reviewers suggestion: those reviewers see the same harmless-looking release, and a run waiting for approval holds the workflow's concurrency group. Links the migration guide and agents.md to the section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(ci): restore the default-branch environment advice A merged PR's closed run has the branch it merged into as its ref, so an environment restricted to the default branch accepts the publish jobs it triggers. The earlier warning used the general pull_request ref, which GitHub documents an exception to for merges. Label-triggered retries may still be rejected. Also says that the template's immediate-release job needs an Actions-bot bypass on main, which voids Code Owners review for every workflow; that each standing-PR update can dismiss the standing PR's approval; and qualifies the release-branch lock, agents.md and troubleshooting.md to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #728
Made with Cursor
This PR appears safe to merge.Summary
Replaces two local documentation references in
templates/workflows/standing-pr.ymlwith full GitHub URLs.Reviews (1) · Last reviewed commit: "docs(templates): link standing-pr.yml co..." · Reviewed by Greptile