Skip to content

feat(launchpack): add driver-independent packaging service - #1766

Merged
joeykchen merged 2 commits into
goplus:devfrom
joeykchen:feat/launchpack
Aug 21, 2026
Merged

feat(launchpack): add driver-independent packaging service#1766
joeykchen merged 2 commits into
goplus:devfrom
joeykchen:feat/launchpack

Conversation

@joeykchen

Copy link
Copy Markdown
Contributor

Summary

  • add a reusable launchpack service that packages launchers without a local XGo driver
  • resolve and verify runtime bundles, project payloads, source/native bridges, and generated launchers
  • keep runtime acquisition and payload assembly behind a small configuration API

Verification

  • go test -count=1 -race ./...
  • go vet ./internal/launchpack
  • Windows amd64 cross-compile of internal/launchpack
  • gofmt and git diff checks

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff for runtime acquisition, project/payload assembly, source-bridge compilation, launcher generation, validation, cleanup, and cross-file identity contracts. I found no actionable PR-introduced correctness, security, performance, or compatibility issue meeting the review threshold.

Verification: go test -count=1 ./internal/launchpack, go test -race -count=1 ./internal/launchpack, go vet ./internal/launchpack, and git diff --check all pass. A full go test -count=1 ./... run reaches an existing failure in internal/projectpolicy (TestPortableConfigSnapshotRejectsIdentityAndContentDrift), outside this PR's changed files.

@joeykchen
joeykchen merged commit d3f0177 into goplus:dev Aug 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant