Skip to content

fix(runnative): propagate isolated session roots - #1772

Merged
joeykchen merged 1 commit into
goplus:devfrom
joeykchen:fix/runnative-session-env
Aug 21, 2026
Merged

fix(runnative): propagate isolated session roots#1772
joeykchen merged 1 commit into
goplus:devfrom
joeykchen:fix/runnative-session-env

Conversation

@joeykchen

@joeykchen joeykchen commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • run native Engine children through the shared interpreted-session command path
  • replace stale root variables with validated project, asset, and session roots
  • remove duplicate Engine argument rewriting

Verification

  • go test ./...
  • go vet ./...
  • go test -race ./cmd/spx/internal/command ./internal/interpruntime
  • spx runnative -headless on .tmp/Coding-Course-49 ran until interrupted

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff for the pack-mode runtime handoff and interpreted-session root propagation. The new command preparation keeps SessionDir authoritative for --path, replaces stale root environment variables, and preserves the existing asset/session setup contract; the affected callers and platform-specific test helper are consistent with that behavior.

Validation completed with go test ./cmd/spx/internal/command ./internal/interpruntime, go vet ./cmd/spx/internal/command ./internal/interpruntime, and go test -race ./cmd/spx/internal/command ./internal/interpruntime. No actionable correctness, security, performance, or maintainability findings meet the review threshold.

@joeykchen
joeykchen merged commit c7148e8 into goplus:dev Aug 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant