fix(create-plugin): respect development flag for GF_DEFAULT_APP_MODE#2598
Open
nickmopen wants to merge 1 commit intografana:mainfrom
Open
fix(create-plugin): respect development flag for GF_DEFAULT_APP_MODE#2598nickmopen wants to merge 1 commit intografana:mainfrom
nickmopen wants to merge 1 commit intografana:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, the
.config/Dockerfiletemplate hardcodedENV GF_DEFAULT_APP_MODE "development"unconditionally, meaning Grafana always started in development mode regardless of thedevelopmentbuild arg passed to docker compose. This causedbuildInfo.envto always report"development"in the browser, making it impossible to test plugins running against a production Grafana instance.This PR fixes the issue by:
ENV GF_DEFAULT_APP_MODE "development"from the DockerfileGF_DEFAULT_APP_MODEdynamically inentrypoint.sh— defaults todevelopment(preserving existing behaviour), and switches toproductiononly whenDEV=falseWhich issue(s) this PR fixes:
Fixes #2171
Special notes for your reviewer:
GF_DEFAULT_APP_MODEis only explicitly set to"production"whenDEVELOPMENT=falseis passed to docker compose. All other cases fall through to Grafana's own default which isdevelopment.DEVELOPMENT=false docker compose up(verifiedGF_DEFAULT_APP_MODE=productionin PID 1 env) andDEVELOPMENT=true docker compose up(verifiedGF_DEFAULT_APP_MODE=development).