Skip to content

fix(create-plugin): respect development flag for GF_DEFAULT_APP_MODE #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nickmopen wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

fix(create-plugin): respect development flag for GF_DEFAULT_APP_MODE #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/create-plugin/templates/common/.config/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ ENV DEV "${development}"
ENV GF_AUTH_ANONYMOUS_ORG_ROLE "Admin"
ENV GF_AUTH_ANONYMOUS_ENABLED "${anonymous_auth_enabled}"
ENV GF_AUTH_BASIC_ENABLED "false"
# Set development mode so plugins can be loaded without the need to sign
ENV GF_DEFAULT_APP_MODE "development"
# GF_DEFAULT_APP_MODE is set dynamically in entrypoint.sh based on the DEV build arg


LABEL maintainer="Grafana Labs <hello@grafana.com>"
Expand Down
5 changes: 5 additions & 0 deletions packages/create-plugin/templates/common/.config/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#!/bin/sh

# Default to development mode; switch to production when DEV=false
if [ "${DEV}" = "false" ]; then
export GF_DEFAULT_APP_MODE="production"
fi

if [ "${DEV}" = "false" ]; then
echo "Starting test mode"
exec /run.sh
Expand Down