Create Plugin: Revert @grafana dep pins and re-enable test-updates CI job#2618
Closed
Create Plugin: Revert @grafana dep pins and re-enable test-updates CI job#2618
Conversation
Contributor
sunker
added
patch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the temporary dependency pinning workaround in the create-plugin common template now that upstream @grafana/* publishing is resolved, and restores CI coverage for the create-plugin update flow.
Changes:
- Bump the default Grafana Docker dev-server version in the common template to
12.4.3. - Switch
@grafana/{data,i18n,runtime,ui,schema}template dependencies from exact pins back to caret ranges (^12.4.3) to allow patch updates. - Re-enable the
test-updatesGitHub Actions job in CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/create-plugin/templates/common/.config/docker-compose-base.yaml | Updates the default Grafana version used by the generated Docker setup to 12.4.3. |
| packages/create-plugin/templates/common/_package.json | Restores caret ranges for core @grafana/* runtime deps in the scaffolded plugin template. |
| .github/workflows/ci.yml | Re-enables the test-updates job to validate upgrading a plugin scaffolded with an older create-plugin version. |
| working-directory: ./packed-artifacts | ||
|
|
||
| - name: Test create-plugin update command | ||
| run: npx create-plugin update --force |
hugohaggmark
approved these changes
May 7, 2026
github-project-automation
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
Contributor
Author
|
Closing in favour of #2614 |
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reverts the temporary workaround introduced in #2577, now that the NPM publishing issue for
@grafana/*packages in grafana/grafana is resolved. The pinned exact versions (12.4.2) are replaced with a caret range (^12.4.3) to allow patch updates again, the Docker dev-server default is bumped to12.4.3to align, and thetest-updatesCI job is restored.Which issue(s) this PR fixes:
Reverts #2577
Special notes for your reviewer: