Skip to content

Create Plugin: Revert @grafana dep pins and re-enable test-updates CI job #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunker wants to merge 1 commit into from
+82 −82
Closed

Create Plugin: Revert @grafana dep pins and re-enable test-updates CI job #2618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 76 additions & 76 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,82 +174,82 @@ jobs:
GRAFANA_ACCESS_POLICY_TOKEN: ${{ fromJSON(steps.get-secrets.outputs.secrets).GRAFANA_ACCESS_POLICY_TOKEN }}
run: sign-plugin --rootUrls http://www.example.com --signatureType private
working-directory: ./${{ env.WORKING_DIR }}
# Temporarily disable to prevent failures due to NPM package publishing in grafana/grafana. Put back to 5.27.1 once resolved.
# test-updates:
# name: Test create-plugin update command
# runs-on: ubuntu-x64
# if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci')"
# needs: [test]
# env:
# WORKING_DIR: 'myorg-nobackend-panel'
# steps:
# - name: Setup nodejs
# uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
# with:
# node-version: '24'

# - name: Scaffold plugin using the earliest create-plugin version mentioned in migrations
# run: npx -y @grafana/create-plugin@5.27.1 --plugin-name='no-backend' --org-name='myorg' --plugin-type='panel'

# - name: Install generated plugin dependencies
# run: npm install --no-audit
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Download packed artifacts
# uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
# with:
# name: packed-artifacts
# path: ./packed-artifacts

# - name: Install npm packages globally
# run: for file in *.tgz; do npm install -g "$file"; done
# working-directory: ./packed-artifacts

# - name: Test create-plugin update command
# run: npx create-plugin update --force
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Lint plugin frontend
# run: npm run lint
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Typecheck plugin frontend
# run: npm run typecheck
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Build plugin frontend
# run: npm run build
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Test plugin frontend
# run: npm run test:ci
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Install playwright dependencies
# run: npm exec playwright install --with-deps chromium
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Start grafana server for e2e tests (10.4.0)
# run: |
# ANONYMOUS_AUTH_ENABLED=false docker compose build --no-cache
# docker compose up -d
# env:
# GRAFANA_VERSION: '10.4.0'
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Wait for grafana server (10.4.0)
# uses: grafana/plugin-actions/wait-for-grafana@752a92aaebfcd83121acc27293c93b7013d30deb # wait-for-grafana/v1.0.1
# with:
# url: http://localhost:3000/login

# - name: Run e2e tests (10.4.0)
# id: run-e2e-tests-min-version
# run: npm run e2e
# working-directory: ./${{ env.WORKING_DIR }}

# - name: Stop grafana docker (10.4.0)
# run: docker compose down
# working-directory: ./${{ env.WORKING_DIR }}

test-updates:
name: Test create-plugin update command
runs-on: ubuntu-x64
if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci')"
needs: [test]
env:
WORKING_DIR: 'myorg-nobackend-panel'
steps:
- name: Setup nodejs
uses: actions/setup-node@6044e13b5dc448c55e2357c09f80417699197238 # v6.2.0
with:
node-version: '24'

- name: Scaffold plugin using the earliest create-plugin version mentioned in migrations
run: npx -y @grafana/create-plugin@5.27.1 --plugin-name='no-backend' --org-name='myorg' --plugin-type='panel'

- name: Install generated plugin dependencies
run: npm install --no-audit
working-directory: ./${{ env.WORKING_DIR }}

- name: Download packed artifacts
uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131 # v7.0.0
with:
name: packed-artifacts
path: ./packed-artifacts

- name: Install npm packages globally
run: for file in *.tgz; do npm install -g "$file"; done
working-directory: ./packed-artifacts

- name: Test create-plugin update command
run: npx create-plugin update --force
working-directory: ./${{ env.WORKING_DIR }}

- name: Lint plugin frontend
run: npm run lint
working-directory: ./${{ env.WORKING_DIR }}

- name: Typecheck plugin frontend
run: npm run typecheck
working-directory: ./${{ env.WORKING_DIR }}

- name: Build plugin frontend
run: npm run build
working-directory: ./${{ env.WORKING_DIR }}

- name: Test plugin frontend
run: npm run test:ci
working-directory: ./${{ env.WORKING_DIR }}

- name: Install playwright dependencies
run: npm exec playwright install --with-deps chromium
working-directory: ./${{ env.WORKING_DIR }}

- name: Start grafana server for e2e tests (10.4.0)
run: |
ANONYMOUS_AUTH_ENABLED=false docker compose build --no-cache
docker compose up -d
env:
GRAFANA_VERSION: '10.4.0'
working-directory: ./${{ env.WORKING_DIR }}

- name: Wait for grafana server (10.4.0)
uses: grafana/plugin-actions/wait-for-grafana@752a92aaebfcd83121acc27293c93b7013d30deb # wait-for-grafana/v1.0.1
with:
url: http://localhost:3000/login

- name: Run e2e tests (10.4.0)
id: run-e2e-tests-min-version
run: npm run e2e
working-directory: ./${{ env.WORKING_DIR }}

- name: Stop grafana docker (10.4.0)
run: docker compose down
working-directory: ./${{ env.WORKING_DIR }}

generate-plugins:
name: Test plugin scaffolding
Expand Down
2 changes: 1 addition & 1 deletion packages/create-plugin/templates/common/.config/docker-compose-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
context: .
args:
grafana_image: ${GRAFANA_IMAGE:-{{~grafanaImage~}} }
grafana_version: ${GRAFANA_VERSION:-12.4.0}
grafana_version: ${GRAFANA_VERSION:-12.4.3}
development: ${DEVELOPMENT:-false}
anonymous_auth_enabled: ${ANONYMOUS_AUTH_ENABLED:-true}
ports:
Expand Down
10 changes: 5 additions & 5 deletions packages/create-plugin/templates/common/_package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@
},
"dependencies": {
"@emotion/css": "11.10.6",
"@grafana/data": "12.4.2",
"@grafana/i18n": "12.4.2",
"@grafana/runtime": "12.4.2",
"@grafana/ui": "12.4.2",
"@grafana/schema": "12.4.2",{{#if_eq pluginType "scenesapp" }}
"@grafana/data": "^12.4.3",
"@grafana/i18n": "^12.4.3",
"@grafana/runtime": "^12.4.3",
"@grafana/ui": "^12.4.3",
"@grafana/schema": "^12.4.3",{{#if_eq pluginType "scenesapp" }}
"@grafana/scenes": "{{ scenesVersion }}",{{/if_eq}}
"react": "^18.3.0",
"react-dom": "^18.3.0"{{#if isAppType}},
Expand Down
Loading