javascript: Fix failing test and make script/test exit non-interactively - #154
Open
adamnfish-gu wants to merge 1 commit into
Open
javascript: Fix failing test and make script/test exit non-interactively#154adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
pairingTest() returned false while the test expected true. It now returns true, and the test is named for what it checks. package.json ran `jest --watchAll` and script/test added --watch, so the runner never exited. package.json now runs plain jest and script/test takes an explicit --watch flag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 7, 2026
bryophyta
reviewed
Aug 7, 2026
| const { pairingTest } = require('.'); | ||
|
|
||
| test('a failing test', () => { | ||
| test('pairingTest returns true', () => { |
There was a problem hiding this comment.
the intent here seems to have changed, as well as the behaviour
it looks to me as though originally this was meant to be a failing test, along the lines of "Red-Green TDD", to verify that the test setup is actually working.
if we're adding a CI step that runs the tests then this is a good reason to switch to using a passing test rather than a failing one, but as this goal isn't mentioned in the PR description I thought it worth flagging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairingTest() returned false while the test expected true. It now returns true, and the test is named for what it checks.
package.json ran
jest --watchAlland script/test added --watch, so the runner never exited. package.json now runs plain jest and script/test takes an explicit --watch flag.Base
platform/tool-versions-ci(#144), so the diff shows only this branch's changes. Merge #144 first.Part of #143.