typescript-node: Fix yarn lockfile, test value, and script/test for CI - #160
Open
adamnfish-gu wants to merge 1 commit into
Open
typescript-node: Fix yarn lockfile, test value, and script/test for CI#160adamnfish-gu wants to merge 1 commit into
adamnfish-gu wants to merge 1 commit into
Conversation
The project had a Yarn Classic v1 yarn.lock alongside a .yarnrc.yml configured for Yarn Berry and a .yarn/install-state.gz. The sibling javascript and javascript-esm projects both use Yarn Berry 3. Deletes the v1 yarn.lock and regenerates it with Yarn 3.8.7. Adds a packageManager field to package.json to pin the choice. myConst was false while the test expected true; it now returns true. script/test ran `yarn test --watch`, which never exits. It now runs once, with the watch loop behind --watch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 7, 2026
bryophyta
approved these changes
Aug 7, 2026
bryophyta
left a comment
bryophyta
left a comment
There was a problem hiding this comment.
As mentioned in the corresponding JS PR I suspect that the test was failing intentionally, but as long as the change to a passing test is intentional then this looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project had a Yarn Classic v1 yarn.lock alongside a .yarnrc.yml configured for Yarn Berry and a .yarn/install-state.gz. The sibling javascript and javascript-esm projects both use Yarn Berry 3.
Deletes the v1 yarn.lock and regenerates it with Yarn 3.8.7. Adds a packageManager field to package.json to pin the choice.
myConst was false while the test expected true; it now returns true. script/test ran
yarn test --watch, which never exits. It now runs once, with the watch loop behind --watch.Base
platform/tool-versions-ci(#144), so the diff shows only this branch's changes. Merge #144 first.Part of #143.