Update ContentAtomBlockElement to include caption field - #15717
Merged
simonbyford merged 11 commits intoMay 20, 2026
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Contributor
Author
|
Current build failure is due to a model mismatch issue |
This was referenced Apr 20, 2026
simonbyford
reviewed
Apr 24, 2026
simonbyford
reviewed
Apr 24, 2026
simonbyford
reviewed
Apr 24, 2026
simonbyford
reviewed
Apr 24, 2026
simonbyford
reviewed
Apr 24, 2026
Contributor
Possibly this happens if you attempt to manually edit schemas instead of running |
simonbyford
force-pushed
the
rjr-bump-capi-model-to-include-new-video-caption-field
branch
from
May 19, 2026 13:12
1109401 to
5837b46
Compare
simonbyford
marked this pull request as ready for review
May 19, 2026 13:30
simonbyford
force-pushed
the
rjr-bump-capi-model-to-include-new-video-caption-field
branch
from
May 20, 2026 10:33
5837b46 to
a0bb3ac
Compare
simonbyford
approved these changes
May 20, 2026
github-actions
Bot
removed
the
run_chromatic
simonbyford
force-pushed
the
rjr-bump-capi-model-to-include-new-video-caption-field
branch
from
May 20, 2026 13:38
a0bb3ac to
436110f
Compare
simonbyford
force-pushed
the
rjr-bump-capi-model-to-include-new-video-caption-field
branch
from
May 20, 2026 13:40
436110f to
fb9c872
Compare
github-actions
Bot
removed
the
run_chromatic
Contributor
Author
|
Now that this PR is passing its Chromatic tests, I'm happy for the work to merge into PROD |
simonbyford
deleted the
rjr-bump-capi-model-to-include-new-video-caption-field
branch
May 20, 2026 14:31
|
Seen on PROD (created by @RikRootsGuardian and merged by @simonbyford 9 minutes and 38 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Does two things:
captionfield which - if present - overrides the existing video caption. This is enabled by: Bump models to include new video captions field frontend#2872812pxbecause this is what theYoutubeBlockElementuses.Testing
This has been tested by running DCR locally and manually fixing the value of
element.caption.Empty caption
Non-empty caption
Broader context
Composer users need an easier way to update captions for video atoms. The current process of updating them in MAM is laborious and prevents us from showing different captions for the same video on different articles, which is sometimes helpful.
The work in this PR is part of a chain of PRs to add a new
captionfield to the atom editor in Composer. This field should:titlevalue, set in the Media Atom Maker toolSee the Rethink media atom captions in Composer issue (in the Arts&Pubs project) for further details
Testing plan document