Bump models to include new video captions field - #28728
Conversation
|
Concerning the build error:
... I think I need to perform a pre-release of the content-api-scala-client library and update the
|
There was a problem hiding this comment.
This PR just needs to transform a contentatom from CAPI into a MediaAtomBlockElement which DCR can render. Take a look at this PR which does something very similar:
In our case we'll need to pass in something like:
element.contentAtomTypeData.flatMap(_.caption)
There was a problem hiding this comment.
We shouldn't need to touch this part of the system which deals with email templates
There was a problem hiding this comment.
Removed change
simonbyford
left a comment
There was a problem hiding this comment.
I've included some testing instructions in the PR description which should help check whether this change has worked correctly!
There was a problem hiding this comment.
I've been trying to understand the purpose of this file and I believe it is no longer used.
According to this comment, transformation logic used to belong in BlockElement.scala but now lives in PageElement.scala.
Therefore I suggest we omit this change.
|
I agree that this is ready to merge, following the successful testing |
|
Seen on ADMIN-PROD (created by @RikRootsGuardian and merged by @simonbyford 21 minutes and 44 seconds ago)
|
|
Seen on FRONTS-PROD (created by @RikRootsGuardian and merged by @simonbyford 21 minutes and 59 seconds ago)
|



What does this change?
Composer users need an easier way to update captions for video atoms. The current process of updating them in MAM is laborious and prevents us from showing different captions for the same video on different articles, which is sometimes helpful.
The work in this PR is part of a chain of PRs to add a new
captionfield to the atom editor in Composer. This field should:titlevalue, set in the Media Atom Maker toolSee the Rethink media atom captions in Composer issue (in the Arts&Pubs project) for further details
Testing
We have tested this by running frontend locally and also running DCR locally and then visiting:
http://localhost:9000/science/grrlscientist/2012/aug/07/3.json?dcr
And observing
captionis being populated correctly in the relevantMediaAtomBlockElementelement.Deployment
Some PRs include model pre-releases. Before deploying to PROD, these pre-releases will need to become full releases, and code in affected PRs updated to reflect these changes.
TODO: come up with an appropriate sequencing for merging and closing PRs. The PRs do not need to all be deployed at the same time, but some - such as those requiring associated releases - need to be performed before others.
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)