Repository navigation
fix(ml): finish window backup - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://goal-jira.atlassian.net/browse/HACK-186
Production verification found that the streamed backup script could finish with exit 0 after
docker compose startconsumed the rest of its stdin. The previous ML deploy steps showed a container restart but noequipment window saved:line, and the production snapshot directory had no completedequipment-*snapshot.Redirect Docker stdin, add a regression that runs the script as
bash -swith a draining command, and require the completion marker before the deploy switches images. Local suite: 72 passed. Reviewed by the requested critic agent before opening this PR.