fix(settings): trim the browser tab title before storing - #74
Merged
Conversation
Re-lands the trim fix from the content review of #63 (configurable tab title): #63 merged at its pre-fix head, so this follow-up delivers it. The setter persisted the raw value; only the resolver trimmed for display, so a padded/whitespace-only tab title was stored verbatim. Trim on store and normalize blank to '' (the resolver still falls back to the default). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ETfeXXs8R5ciw6nGxGYj2C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the trim fix from the content review of #63 (configurable browser tab title). #63 was merged at its pre-fix head (out of band), so its review fix — trimming the stored value — never reached main; this follow-up delivers it.
What:
setBrowserTabTitlepersisted the raw value; only the resolver trimmed for display, so a padded or whitespace-only tab title was stored verbatim. Trim on store and normalize blank to''(the resolver still falls back to the defaultSKip).🤖 Generated with Claude Code