Skip to content

fix(settings): trim the browser tab title before storing #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mairas merged 1 commit into from
Jul 1, 2026
Merged

fix(settings): trim the browser tab title before storing #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/app/core/services/settings.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,9 @@ export class SettingsService {
}

public setBrowserTabTitle(title: string) {
this.browserTabTitle.next(title);
// Trim before storing so a padded/whitespace-only value isn't persisted (the resolver already
// trims for display; this keeps the saved config clean and blank values normalized to '').
this.browserTabTitle.next((title ?? '').trim());
const appConf = this.buildAppStorageObject();

if (this.useSharedConfig) {
Expand Down
Loading