fix: document PyYAML and reject broken take lists - #1
Merged
Merged
Conversation
This was referenced Aug 26, 2026
hc-ui
marked this pull request as ready for review
August 26, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
takes:list items (strings / nulls) raiseParseErrorinstead of being silently droppedstore.pyimportsCharacterandSceneused by the helperscompileallsyntax check inside the existing pytest job (token cannot edit Actions workflows)Verification
Local:
pytest→ all passed (including the new take-list case)No PR template in this repo.
Risk / decision
Stricter load behavior: a malformed take list that used to skip bad items will now fail. That is the intended fix for silent data loss.