Skip to content

Cx Organization#1884

Merged
brownbaerchen merged 34 commits into
mainfrom
cx/workflow_action_refactor
May 20, 2026
Merged

Cx Organization#1884
brownbaerchen merged 34 commits into
mainfrom
cx/workflow_action_refactor

Conversation

@JuanPedroGHM

@JuanPedroGHM JuanPedroGHM commented Jun 13, 2025

Copy link
Copy Markdown
Member

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

Goal is to organize our workflows by modularizing certain steps and jobs.
Reusable workflows should be turned into actions, that can be added onto larger workflows.

Anger towards #1937 made me finish this out of spite. It does all the changes proposed. Let's talk about what's missing.

Benchmarks are also working again.

What are we getting from this

  • More detailed test reports in gitlab and codecov (allegedly)
  • Actions that are easier to maintain and workflows that are easier to plan.

TODO

  • Clean-up secrets and old tokens
  • Change GH_TOKEN, CB cannot comment on pr's at the moment.
  • Restore full CI runs (after pr approved, and on main?)
  • Somehow test the weekly workflow.
  • Make sure special cases CI cases (support) are somehow handled properly.

See #1874 Cx section for rationale.

Changes proposed:

  • Weekly actions packed into weekly workflow
  • A single Github CI Action
  • A single Codebase CI Action
  • A single Benchmark trigger action
  • A PR open/update workflow
  • A PR approve workflow
  • A push to main workflow
  • NO MORE THANKING YOU FOR THE PR!

@JuanPedroGHM JuanPedroGHM added this to the 1.6 milestone Jun 13, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Jun 13, 2025
@JuanPedroGHM JuanPedroGHM linked an issue Aug 12, 2025 that may be closed by this pull request
@ClaudiaComito ClaudiaComito modified the milestones: 1.6, 1.7.0 Aug 25, 2025
@github-actions

github-actions Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions Bot added the stale label Nov 3, 2025
@JuanPedroGHM JuanPedroGHM removed the stale label Nov 4, 2025
@JuanPedroGHM JuanPedroGHM modified the milestones: 1.7.0, 2.0 Dec 8, 2025
@brownbaerchen

Copy link
Copy Markdown
Collaborator

What is the status of this PR? Is this still relevant after #2139? Some things like removing thanking for PR are certainly still relevant but may be better merged separately.

@JuanPedroGHM JuanPedroGHM force-pushed the cx/workflow_action_refactor branch from 2f2694c to 7765578 Compare April 23, 2026 13:08
@JuanPedroGHM

Copy link
Copy Markdown
Member Author

Updates based on the review comments:

  • On Push PR also triggers when opening/reopening a PR, to get instant tests.
  • On Push PR, the github tests are closer to the medium tests, testing the oldest and newest python and pytorch versions, without any dependencies. It makes sense to do this, we would rather not find the compatibility issues after a merge to main.
  • Tests will still not run dependabot PR's, I don't think it makes sense 99% of the time, but they can be triggered manually by creating a "fake" commit if we feel the need to test it.

@mtar mtar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some action SHA pinning for security. It's non-critical code though.

Comment thread .github/workflows/push_other.yml Outdated
Comment thread .github/actions/gh_tests/action.yml Outdated
Comment thread .github/actions/gh_tests/action.yml Outdated
brownbaerchen
brownbaerchen previously approved these changes Apr 28, 2026
Comment thread .github/workflows/push_main.yml
@github-project-automation github-project-automation Bot moved this from In Progress to Merge queue in Roadmap Apr 28, 2026
Co-authored-by: Michael Tarnawa <18899420+mtar@users.noreply.github.com>
@JuanPedroGHM

Copy link
Copy Markdown
Member Author

@brownbaerchen From your last comment: changes to github workflows will be tested on PR Open/Update (unless they have dependabot/** branch), to ensure that they work (just like the ones here), but I would say, once they work on the PR, there is no need to test them on main. Many dependabot merges won't clog the CI anymore. Same principle applies to documentation changes, or other non-source code changes.

@JuanPedroGHM

JuanPedroGHM commented May 19, 2026

Copy link
Copy Markdown
Member Author

Benchmarks results - Sponsored by perun

FTPx86-AMD-Milan-Mi250 - CPU - N4 - RUNTIME

Function Value [s] Change % 30 day avg. [s] Last entrie [s]

FTPx86-AMD-Milan-Mi250 - GPU - N4 - RUNTIME

Function Value [s] Change % 30 day avg. [s] Last entrie [s]

Grafana Dashboard
Last updated: 2026-05-20T13:37:26Z

@JuanPedroGHM

JuanPedroGHM commented May 19, 2026

Copy link
Copy Markdown
Member Author

Pipeline running after downgrading ROCM to 6.4, also changed github actions to use mpich, for the tests.

@JuanPedroGHM JuanPedroGHM force-pushed the cx/workflow_action_refactor branch from 788f77a to 1b3fb66 Compare May 20, 2026 11:21

@brownbaerchen brownbaerchen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few skip statements to jobs that should be skipped on forks. Otherwise, this looks really good. Once push to main doesn't trigger codebase CI on forks, it's ready to be merged in my opinion.

Comment thread .github/workflows/push_main.yml
Comment thread .github/workflows/weekly.yml
Comment thread .github/workflows/weekly.yml
Comment thread .github/workflows/weekly.yml
JuanPedroGHM and others added 2 commits May 20, 2026 14:49
Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>
@brownbaerchen brownbaerchen merged commit 034cd7e into main May 20, 2026
14 checks passed
@brownbaerchen brownbaerchen deleted the cx/workflow_action_refactor branch May 20, 2026 14:03
@github-project-automation github-project-automation Bot moved this from Merge queue to Done in Roadmap May 20, 2026
@brownbaerchen

Copy link
Copy Markdown
Collaborator

Thanks, @JuanPedroGHM! This is really a substantial improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[RFC] Technical Debt TODO

4 participants