Cx Organization#1884
Conversation
|
This pull request is stale because it has been open for 60 days with no activity. |
|
What is the status of this PR? Is this still relevant after #2139? Some things like removing thanking for PR are certainly still relevant but may be better merged separately. |
2f2694c to
7765578
Compare
|
Updates based on the review comments:
|
mtar
left a comment
There was a problem hiding this comment.
Some action SHA pinning for security. It's non-critical code though.
Co-authored-by: Michael Tarnawa <18899420+mtar@users.noreply.github.com>
|
@brownbaerchen From your last comment: changes to github workflows will be tested on PR Open/Update (unless they have |
Benchmarks results - Sponsored by perunFTPx86-AMD-Milan-Mi250 - CPU - N4 - RUNTIME
FTPx86-AMD-Milan-Mi250 - GPU - N4 - RUNTIME
Grafana Dashboard |
|
Pipeline running after downgrading ROCM to 6.4, also changed github actions to use mpich, for the tests. |
788f77a to
1b3fb66
Compare
brownbaerchen
left a comment
There was a problem hiding this comment.
I added a few skip statements to jobs that should be skipped on forks. Otherwise, this looks really good. Once push to main doesn't trigger codebase CI on forks, it's ready to be merged in my opinion.
Co-authored-by: Thomas Saupe <39156931+brownbaerchen@users.noreply.github.com>
|
Thanks, @JuanPedroGHM! This is really a substantial improvement! |
Due Diligence
Description
Goal is to organize our workflows by modularizing certain steps and jobs.
Reusable workflows should be turned into actions, that can be added onto larger workflows.
Anger towards #1937 made me finish this out of spite. It does all the changes proposed. Let's talk about what's missing.
Benchmarks are also working again.
What are we getting from this
TODO
See #1874 Cx section for rationale.
Changes proposed: