Use Boost::json in olp-cpp-sdk-dataservice-write#1681
Merged
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom Mar 11, 2026
Merged
Use Boost::json in olp-cpp-sdk-dataservice-write#1681rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
Conversation
Migrating from RapidJSON Relates-To: OCMAM-445 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
This allows to keep other libs untouched until fully migrated to the boost::json and remove write lib dependency from public json wrappers. Alternative solutions tried are: - add boost json wrappers to the same files in the core but to additional namespace - changes in core, json still exposed - move boost json wrappers from core to internal for the repository include location and add it to all DataSDK projects - huge change Relates-To: OCMAM-445 Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature_boost_json #1681 +/- ##
=====================================================
Coverage ? 80.48%
=====================================================
Files ? 354
Lines ? 14060
Branches ? 1523
=====================================================
Hits ? 11316
Misses ? 2124
Partials ? 620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrey-kashcheev
approved these changes
Mar 11, 2026
mykolamalik
approved these changes
Mar 11, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating from RapidJSON
Copy json implementation wrappers to write lib
This allows to keep other libs untouched until fully migrated to the boost::json and remove write lib dependency from public json wrappers.
Alternative solutions tried are:
Relates-To: OCMAM-445