Skip to content

Use Boost::json in olp-cpp-sdk-dataservice-write#1681

Merged
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-to-write-copy-includes
Mar 11, 2026
Merged

Use Boost::json in olp-cpp-sdk-dataservice-write#1681
rustam-gamidov-here merged 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-to-write-copy-includes

Conversation

@rustam-gamidov-here
Copy link
Collaborator

@rustam-gamidov-here rustam-gamidov-here commented Mar 10, 2026

Migrating from RapidJSON
Copy json implementation wrappers to write lib

This allows to keep other libs untouched until fully migrated to the boost::json and remove write lib dependency from public json wrappers.
Alternative solutions tried are:

  • add boost json wrappers to the same files in the core but to additional namespace, results in changes in core, json still exposed
  • move boost json wrappers from core to internal for the repository include location and add it to all DataSDK projects, results in a huge change

Relates-To: OCMAM-445

Migrating from RapidJSON

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
This allows to keep other libs untouched until fully migrated to the
boost::json and remove write lib dependency from public json wrappers.
Alternative solutions tried are:
 - add boost json wrappers to the same files in the core but to
   additional namespace - changes in core, json still exposed
 - move boost json wrappers from core to internal for the repository
   include location and add it to all DataSDK projects - huge change

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here rustam-gamidov-here changed the title Rga/ocmam 445 boost to write copy includes Use Boost::json in olp-cpp-sdk-dataservice-write Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 89.88764% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature_boost_json@9a5efa0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/src/generated/serializer/IndexInfoSerializer.cpp 66.67% 8 Missing and 2 partials ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 72.73% 7 Missing and 2 partials ⚠️
...src/generated/serializer/PublicationSerializer.cpp 90.91% 0 Missing and 2 partials ⚠️
...write/src/generated/serializer/SerializerWrapper.h 92.31% 0 Missing and 2 partials ⚠️
...ataservice-write/src/generated/parser/JsonParser.h 85.71% 1 Missing ⚠️
...service-write/src/generated/parser/ParserWrapper.h 96.30% 0 Missing and 1 partial ⚠️
...ite/src/generated/parser/VersionResponseParser.cpp 0.00% 1 Missing ⚠️
...nerated/serializer/PublishPartitionsSerializer.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature_boost_json    #1681   +/-   ##
=====================================================
  Coverage                      ?   80.48%           
=====================================================
  Files                         ?      354           
  Lines                         ?    14060           
  Branches                      ?     1523           
=====================================================
  Hits                          ?    11316           
  Misses                        ?     2124           
  Partials                      ?      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here rustam-gamidov-here merged commit 2b8f6c6 into feature_boost_json Mar 11, 2026
24 checks passed
@rustam-gamidov-here rustam-gamidov-here deleted the rga/ocmam-445-boost-to-write-copy-includes branch March 11, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants