Conversation
This ensure that when importing a server, the plan does not propose a public network update, forcing a server power cycle.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
===========================================
- Coverage 73.06% 37.90% -35.17%
===========================================
Files 116 116
Lines 12800 12804 +4
===========================================
- Hits 9352 4853 -4499
- Misses 2372 7885 +5513
+ Partials 1076 66 -1010
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A optional attribute with its diff suppressed when undefined is in the end a computed value.
lukasmetzner
approved these changes
Sep 9, 2026
lukasmetzner
left a comment
Contributor
There was a problem hiding this comment.
Is there an import e2e test we can add, or extend to cover this case?
jooola
marked this pull request as draft
September 9, 2026 07:59
Member
Author
|
Ah my bad, I am still cooking on this one. |
Member
Author
|
This change it too "big", we do not have a grasp of the repercussion of such a change. Closing in favor of #1534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensure that when importing a server, the plan does not propose a public network update, forcing a server power cycle.