Skip to content

feat(server): always read public_net config into state - #1527

Closed
jooola wants to merge 2 commits into
mainfrom
save-server-public_net
Closed

jooola wants to merge 2 commits into
mainfrom
save-server-public_net

Conversation

@jooola

@jooola jooola commented Sep 8, 2026

Copy link
Copy Markdown
Member

This ensure that when importing a server, the plan does not propose a public network update, forcing a server power cycle.

This ensure that when importing a server, the plan does not propose a public network update, forcing a server power cycle.
@jooola
jooola requested a review from a team as a code owner September 8, 2026 10:19
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.90%. Comparing base (9e41e2b) to head (d798ea7).

Files with missing lines Patch % Lines
internal/server/resource.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1527       +/-   ##
===========================================
- Coverage   73.06%   37.90%   -35.17%     
===========================================
  Files         116      116               
  Lines       12800    12804        +4     
===========================================
- Hits         9352     4853     -4499     
- Misses       2372     7885     +5513     
+ Partials     1076       66     -1010     
Flag Coverage Δ
e2e ?
unit 37.90% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

A optional attribute with its diff suppressed when undefined is in the end a computed value.

@lukasmetzner lukasmetzner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an import e2e test we can add, or extend to cover this case?

@jooola
jooola marked this pull request as draft September 9, 2026 07:59
@jooola

jooola commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

Ah my bad, I am still cooking on this one.

@jooola

jooola commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

This change it too "big", we do not have a grasp of the repercussion of such a change. Closing in favor of #1534

@jooola jooola closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants