Skip to content

feat(server): always read public_net config into state #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jooola wants to merge 2 commits into from
Closed

feat(server): always read public_net config into state #1527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312fe47
feat(server): always read public_net config into state
jooola Sep 8, 2026
d798ea7
fix: mark public_net as computer and remove diff suppression
jooola Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions internal/server/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,7 @@ func Resource() *schema.Resource {
"public_net": {
Type: schema.TypeSet,
Optional: true,
DiffSuppressFunc: func(_, _, _ string, d *schema.ResourceData) bool {
// Diff is only valid if "public_net" resource is set in
// terraform configuration.
_, ok := d.GetOk("public_net")
return !ok // Negate because we do **not** want to suppress the diff.
},
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"ipv4_enabled": {
Expand Down Expand Up @@ -1257,20 +1252,30 @@ func getServerAttributes(d *schema.ResourceData, s *hcloud.Server, forceSetNetwo
"firewall_ids": firewallIDs,
"primary_disk_size": s.PrimaryDiskSize,
}
resPublicNet := []map[string]any{{}}

if s.PublicNet.IPv4.IsUnspecified() {
res["ipv4_address"] = nil
resPublicNet[0]["ipv4_enabled"] = false
} else {
res["ipv4_address"] = s.PublicNet.IPv4.IP.String()
resPublicNet[0]["ipv4_enabled"] = true
resPublicNet[0]["ipv4"] = s.PublicNet.IPv4.ID
}

if len(s.PublicNet.IPv6.IP) == 0 {
// No IPv6 Primary IP assigned
res["ipv6_address"] = nil
resPublicNet[0]["ipv6_enabled"] = false
} else {
// Set first IP in assigned subnet range
res["ipv6_address"] = s.PublicNet.IPv6.IP.String() + "1"
resPublicNet[0]["ipv6_enabled"] = true
resPublicNet[0]["ipv6"] = s.PublicNet.IPv6.ID
}

res["public_net"] = resPublicNet

if s.Image != nil {
if s.Image.Name != "" && util.FormatID(s.Image.ID) != d.Get("image") {
// Only use the image name if the image is official (Name != "")
Expand Down
Loading