PR13/15: pic-sure-auth-microapp (psama) — adopt parent + BOM (Java 25)#272
Open
Gcolon021 wants to merge 1 commit into
Open
PR13/15: pic-sure-auth-microapp (psama) — adopt parent + BOM (Java 25)#272Gcolon021 wants to merge 1 commit into
Gcolon021 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gcolon021
force-pushed
the
psar/12-logging
branch
from
July 14, 2026 18:09
c2a6dce to
efbbde3
Compare
Gcolon021
force-pushed
the
psar/13-auth-microapp
branch
from
July 14, 2026 18:09
ebdd656 to
874afc7
Compare
Gcolon021
changed the title
…it4 + mismatched Jackson pins Carved from pic_sure_api_mono_repo @ carve-source. Adds the module to the reactor, the okio convergence pin, and a reactor-aware path-filtered CI workflow.
Gcolon021
force-pushed
the
psar/12-logging
branch
from
July 14, 2026 18:12
efbbde3 to
454b21a
Compare
Gcolon021
force-pushed
the
psar/13-auth-microapp
branch
from
July 14, 2026 18:12
874afc7 to
a3968f9
Compare
Gcolon021
added a commit
that referenced
this pull request
Jul 16, 2026
4.26 cannot parse Java 21 guarded-pattern switches (crashed on psama's AccessRuleService - the documented PR #272 exception). 4.35 parses the whole reactor, so incremental spotless:apply works on every module. The reactor-wide normalization has been dropped per project preference (format incrementally, only files a developer is already changing - no mass reformat). RASPassPortServiceTest.java is kept formatted solely to preserve the two '// gitleaks:allow' annotations on its synthetic JWTs, which keep the secrets-scan gate green; .gitleaksignore is only a scaffold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts psama onto the pic-sure-api reactor: parent+BOM (versionless deps), Java 25, RestClient over
Apache HttpClient 5, drops JUnit4 and the mismatched Jackson pins. Adds the okio 3.6.0 convergence
pin (auth0 SDK transitive skew) and a reactor-aware path-filtered CI workflow targeting the
pic-sure-auth-services child module. Diff vs PR12 = exactly the refactor.
Single commit (documented exception): the refactor commit is byte-identical to the frozen carve-source tree. The usual mechanical spotless-normalize commit is skipped for this module: the repo's pinned Eclipse JDT formatter (4.26) cannot parse the Java 21 guarded-pattern switch in AccessRuleService.java (spotless:apply and spotless:check both crash). Module formatting normalization is deferred to the psar/15 build-gates follow-up (formatter version bump).
Reconciliation with psar libs: none.
Verified: full-reactor
mvn -T1C clean verifygreen from the root; service tree byte-identical tocarve-source; gitleaks clean.
Secrets note:
docker-compose.dev.ymlcarries dev-only literal defaults (MYSQL_ROOT_PASSWORD: password,FLYWAY_PASSWORD=password) — pre-existing carve-source content, vetted as placeholders during the pre-push secrets gate (gitleaks clean).