fix(websocket): polyfill missing ErrorEvent global#371
Merged
Conversation
Node.js has no global ErrorEvent, so `new ErrorEvent(...)` threw a ReferenceError and silently swallowed the user's onError handler.
Member
|
Good catch! Looks good. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js has no global
ErrorEvent(unlikeEvent,MessageEvent, andCloseEvent,which are already polyfilled/native). When the underlying
wssocket emits anerrorevent,upgradeWebSocket's handler doesnew ErrorEvent('error', { error }),which throws a
ReferenceErroron every supported Node version. That error is caughtand passed to the internal
onErrorfallback instead — so the user'sonErrorhandler passed to
upgradeWebSocketis never invoked, and the original error is lost.This adds an
ErrorEventpolyfill following the same pattern as the existingCloseEventone, and adds a test that reproduces the bug by emitting a realerrorevent on the raw socket and asserting the user'sonErrorreceives it.