Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/websocket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,49 @@ export const CloseEvent: typeof globalThis.CloseEvent =
}
}

interface ErrorEventInit extends EventInit {
message?: string
filename?: string
lineno?: number
colno?: number
error?: unknown
}

/**
* Node.js has no global `ErrorEvent`, unlike `Event`/`MessageEvent`/`CloseEvent`.
* @link https://developer.mozilla.org/en-US/docs/Web/API/ErrorEvent
*/
export const ErrorEvent: typeof globalThis.ErrorEvent =
globalThis.ErrorEvent ??
class extends Event {
#eventInitDict

constructor(type: string, eventInitDict: ErrorEventInit = {}) {
super(type, eventInitDict)
this.#eventInitDict = eventInitDict
}

get message(): string {
return this.#eventInitDict.message ?? ''
}

get filename(): string {
return this.#eventInitDict.filename ?? ''
}

get lineno(): number {
return this.#eventInitDict.lineno ?? 0
}

get colno(): number {
return this.#eventInitDict.colno ?? 0
}

get error(): unknown {
return this.#eventInitDict.error ?? null
}
}

const generateConnectionSymbol = () => Symbol('connection')

type WaitForWebSocket = (
Expand Down
40 changes: 40 additions & 0 deletions test/websocket.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,4 +162,44 @@ describe('WebSocket', () => {
await new Promise<void>((resolve) => server.close(() => resolve()))
}
})

it('should call onError with the underlying error when the raw socket errors', async () => {
const app = new Hono()
const receivedError = new Error('boom')
// eslint-disable-next-line @typescript-eslint/no-explicit-any
let rawWs: any
const onErrorCalled = new Promise<Event>((resolve) => {
app.get(
'/ws',
upgradeWebSocket(() => ({
onOpen(_evt, ws) {
rawWs = ws.raw
},
onError(evt) {
resolve(evt)
},
}))
)
})

const { server, address } = await startServer(app)

try {
const ws = new WebSocket(`ws://127.0.0.1:${address.port}/ws`)
await new Promise<void>((resolve, reject) => {
ws.once('open', resolve)
ws.once('error', reject)
})

rawWs.emit('error', receivedError)

const evt = await onErrorCalled
expect(evt).toBeInstanceOf(Event)
expect((evt as ErrorEvent).error).toBe(receivedError)

ws.close()
} finally {
await new Promise<void>((resolve) => server.close(() => resolve()))
}
})
})