Fix CI lint failures: observable locale and coroutine side effects in composables#447
Merged
Conversation
Closed
…sables Agent-Logs-Url: https://github.com/hossain-khan/android-remote-notify/sessions/d4a62f52-5fda-413c-a564-a03acdef3edc Co-authored-by: hossain-khan <99822+hossain-khan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI build issues
Fix CI lint failures: observable locale and coroutine side effects in composables
Apr 25, 2026
hossain-khan
approved these changes
Apr 25, 2026
Code Coverage Report |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=======================================
Coverage 36.16% 36.16%
=======================================
Files 86 86
Lines 2527 2527
Branches 215 215
=======================================
Hits 914 914
Misses 1574 1574
Partials 39 39 🚀 New features to boost your workflow:
|
📊 APK Size AnalysisComparing Generated by Diffuse via diffuse-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing due to 5 lint errors across 3 files — two Compose API misuse categories: non-observable locale reads and coroutine creation during composition.
Changes
NonObservableLocale—AlertCheckLogViewerScreen.kt&FilterLogsUi.ktLocale.getDefault()is not observable in composition and won't trigger recomposition on locale changes. Replaced withLocalConfiguration.current.locales[0]extracted at the top of each composable:CoroutineCreationDuringComposition—DeveloperPortalScreen.ktscope.launchwas called directly in the composition body to show a snackbar. Replaced withLaunchedEffectkeyed onsimulationResult: