Skip to content

Fix CI lint failures: observable locale and coroutine side effects in composables #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hossain-khan merged 2 commits into from
Apr 25, 2026
Merged

Fix CI lint failures: observable locale and coroutine side effects in composables #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d90ae
Initial plan
Copilot Apr 25, 2026
cb1a49f
Fix CI lint errors: use observable locale and LaunchedEffect in compo…
Copilot Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/main/java/dev/hossain/remotenotify/ui/alertchecklog/AlertCheckLogViewerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.Clipboard
import androidx.compose.ui.platform.LocalClipboard
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign
Expand Down Expand Up @@ -613,6 +614,7 @@ private fun ActiveFiltersSection(
modifier: Modifier = Modifier,
onClearFilter: (String) -> Unit,
) {
val locale = LocalConfiguration.current.locales[0]
Column(
modifier =
modifier
Expand Down Expand Up @@ -724,14 +726,14 @@ private fun ActiveFiltersSection(

dateRange.first != null -> {
"From ${
SimpleDateFormat("MMM dd", Locale.getDefault())
SimpleDateFormat("MMM dd", locale)
.format(Date(dateRange.first!!))
}"
}

else -> {
"Until ${
SimpleDateFormat("MMM dd", Locale.getDefault())
SimpleDateFormat("MMM dd", locale)
.format(Date(dateRange.second!!))
}"
}
Expand Down
6 changes: 4 additions & 2 deletions app/src/main/java/dev/hossain/remotenotify/ui/alertchecklog/FilterLogsUi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
Expand All @@ -46,6 +47,7 @@ internal fun FilterBottomSheetContent(
onClearFilters: () -> Unit,
onClose: () -> Unit,
) {
val locale = LocalConfiguration.current.locales[0]
Column(
modifier =
Modifier
Expand Down Expand Up @@ -158,7 +160,7 @@ internal fun FilterBottomSheetContent(
OutlinedTextField(
value =
if (currentState.dateRange.first != null) {
SimpleDateFormat("MMM dd, yyyy", Locale.getDefault())
SimpleDateFormat("MMM dd, yyyy", locale)
.format(Date(currentState.dateRange.first!!))
} else {
""
Expand All @@ -181,7 +183,7 @@ internal fun FilterBottomSheetContent(
OutlinedTextField(
value =
if (currentState.dateRange.second != null) {
SimpleDateFormat("MMM dd, yyyy", Locale.getDefault())
SimpleDateFormat("MMM dd, yyyy", locale)
.format(Date(currentState.dateRange.second!!))
} else {
""
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/dev/hossain/remotenotify/ui/devportal/DeveloperPortalScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,8 @@ fun DeveloperPortalUi(
val scope = rememberCoroutineScope()

// Show snackbar when simulation result changes
state.simulationResult?.let { result ->
scope.launch {
LaunchedEffect(state.simulationResult) {
state.simulationResult?.let { result ->
snackbarHostState.showSnackbar(result)
}
}
Expand Down
Loading