Repository navigation
Punctuate the three bech32 error strings the reader actually sees - #16
Merged
Merged
Conversation
These are not comments. They render on both sites: two of them appear in
the Lightning invoice decoder when a reader breaks an invoice on purpose,
which is the whole point of that control.
Colons rather than dashes, matching the pattern the rest of the file
already uses for its errors ("Too long:", "No separator:"). The tests
assert only the "Mixed case" substring, so nothing depended on the
punctuation.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These aren't comments. They render on both sites, and two of them appear in the Lightning invoice decoder when a reader breaks an invoice on purpose, which is the whole point of that control.
Colons rather than dashes, matching the pattern the rest of the file already uses for its errors (
Too long:,No separator:). Tests assert only theMixed casesubstring, so nothing depended on the punctuation.Everything else in
bitcoin-logicstays exactly as it was.147 tests green; lint, build, typecheck clean.
🤖 Generated with Claude Code