Skip to content

Punctuate the three bech32 error strings the reader actually sees #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotpixelgroup merged 1 commit into from
Aug 26, 2026
Merged

Punctuate the three bech32 error strings the reader actually sees #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/bitcoin-logic/src/lib/bech32.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function decodeBech32(input: string, options: Bech32Options = {}): Bech32
const hasLower = /[a-z]/.test(input);
const hasUpper = /[A-Z]/.test(input);
if (hasLower && hasUpper) {
return { ok: false, error: 'Mixed case — a bech32 string must be all-lower or all-upper, never both.' };
return { ok: false, error: 'Mixed case: a bech32 string must be all-lower or all-upper, never both.' };
}
const str = input.toLowerCase();
const sep = str.lastIndexOf('1');
Expand All @@ -109,7 +109,7 @@ export function decodeBech32(input: string, options: Bech32Options = {}): Bech32
}
const encoding = verifyChecksum(hrp, values);
if (!encoding) {
return { ok: false, error: 'Checksum failed — at least one character here is wrong.' };
return { ok: false, error: 'Checksum failed: at least one character here is wrong.' };
}
return { ok: true, hrp, payload: values.slice(0, -6), encoding };
}
Expand Down Expand Up @@ -158,7 +158,7 @@ export function decodeSegwitAddress(input: string): SegwitAddress | Bech32Error
if (!dec.ok) return dec;
if (dec.payload.length === 0) return { ok: false, error: 'Empty data section after the checksum.' };
const version = dec.payload[0];
if (version > 16) return { ok: false, error: `Invalid witness version ${version} — only 0 through 16 exist.` };
if (version > 16) return { ok: false, error: `Invalid witness version ${version}: only 0 through 16 exist.` };
if (version === 0 && dec.encoding !== 'bech32') {
return { ok: false, error: 'Version 0 witness address must use Bech32 checksum (key_io.cpp:145).' };
}
Expand Down