fix(chart): fail rendering instead of opening the port when a policy rule has no peers - #52
Merged
Merged
Conversation
…rule has no peers A rule with an empty from/to list matches every source or destination, so enabling the ingress restriction without addresses opened the port while looking restrictive. The ingress case now aborts the render with an explicit message, and the internal egress rule is skipped when its list is empty (no destination allowed) rather than rendered wide open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Same fail-open an automated review caught in a sibling chart. With
networkPolicy.ingress.enabled: trueandallowedBlocksleft at its default (empty), the template rendered a rule whosefromlist was empty — and a rule with an emptyfrommatches every source (Kubernetes NetworkPolicy semantics). So the port would be open to the whole cluster and VPC while the policy still looks restrictive.Where this chart also has an internal-egress rule fed by a list, the same applies in reverse: an empty list renders
to:empty, which matches every destination.The fix
Not currently exploitable
The live deployment supplies non-empty lists, so nothing is open today — the bug was latent, waiting for a new environment or a typo.
Verified