Skip to content

fix(chart): fail rendering instead of opening the port when a policy rule has no peers #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtrompier merged 1 commit into from
Aug 6, 2026
+3 −0
Merged

fix(chart): fail rendering instead of opening the port when a policy rule has no peers #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions chart/templates/network-policy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ spec:
matchLabels: {{ include "labels.standard" . | nindent 6 }}
policyTypes:
{{- if .Values.networkPolicy.ingress.enabled }}
{{- if not .Values.networkPolicy.ingress.allowedBlocks }}
{{- fail "networkPolicy.ingress.enabled needs networkPolicy.ingress.allowedBlocks: a rule with no peers under `from` matches every source, so an empty list would open the port instead of restricting it" }}
{{- end }}
- Ingress
{{- end }}
- Egress
Expand Down
Loading