Pass the $worker object to the Logger instance#79
Open
dd32 wants to merge 2 commits intohumanmade:masterfrom
Open
Pass the $worker object to the Logger instance#79dd32 wants to merge 2 commits intohumanmade:masterfrom
dd32 wants to merge 2 commits intohumanmade:masterfrom
Conversation
… methods This allows for the logger to access the workers output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Logger instance does not have access to the STDOUT or STDERR pipes of the worker by default.
This is achievable using something like this in older PHP versions, but this causes PHP Deprecated warnings in newer PHPs.
It would also be possible for the logger to not update it's datastore on
log_job_failed()/log_job_completed()and instead to wait for the following hookRunner.check_workers.job_completedto be fired to then update it's data:Be nice to just have everything accessible though.