Skip to content

Pass the $worker object to the Logger instance #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd32 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass the $worker object to the Logger instance #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e87d1
Pass the Worker object to the Logger log_job_failed/log_job_completed…
dd32 Apr 9, 2025
db5a30e
Update class-logger.php method signatures
dd32 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inc/class-logger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ public function __construct( $db, $table_prefix ) {
$this->table_prefix = $table_prefix;
}

public function log_job_completed( Job $job, $message = '' ) {
public function log_job_completed( Job $job, $message, Worker $worker ) {
$this->log_run( $job->id, 'completed', $message );
}

public function log_job_failed( Job $job, $message = '' ) {
public function log_job_failed( Job $job, $message, Worker $worker ) {
$this->log_run( $job->id, 'failed', $message );
}

Expand Down
4 changes: 2 additions & 2 deletions inc/class-runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ protected function check_workers() {

if ( ! $worker->shutdown() ) {
$worker->job->mark_failed();
$logger->log_job_failed( $worker->job, 'Failed to shutdown worker.' );
$logger->log_job_failed( $worker->job, 'Failed to shutdown worker.', $worker );

/**
* Action after a job has failed.
Expand All @@ -398,7 +398,7 @@ protected function check_workers() {
$this->hooks->run( 'Runner.check_workers.job_failed', $worker, $worker->job, $logger );
} else {
$worker->job->mark_completed();
$logger->log_job_completed( $worker->job );
$logger->log_job_completed( $worker->job, '', $worker );

/**
* Action after a job has failed.
Expand Down