Open
Conversation
sisak
requested review from
bucherarnold,
czenczl,
lacipadar,
martin-nagy,
petrenyi-mark,
rombow and
vasizs
as code owners
Author
|
#96 closed |
speter555
approved these changes
Feb 3, 2024
rombow
reviewed
Feb 8, 2024
| sampleStatus, | ||
| inputValue, | ||
| "updateAllSampleStatusAndInputValue", | ||
| SampleEntity_.STATUS, |
Contributor
There was a problem hiding this comment.
*Service szinten nem szabad hogy legyen barmi rejtett logika, mindent az action szinten keresunk
Author
There was a problem hiding this comment.
A SampleEntity_.STATUS ban csak az entity field neve van stringként generálva az entityből. Így változás biztos.
A két kódrészlet egyenlő:
return wrapValidated(
sampleEntityRepository::updateAllSampleStatusAndInputValue,
sampleStatus,
inputValue,
"updateAllSampleStatusAndInputValue",
"status",
"inputValue"
);
Contributor
There was a problem hiding this comment.
wrapValidated parametereit eredetileg arra szantuk hogy a valos metodus valtozo neveit irja ki a logokban. Logikailag helyes ahogy irod, mivel a vegso mezo neve a entityben SampleEntity_.STATUS csak a metodusban az ehhez tartozo valtozo neve "sampleStatus". Ez most csak tenyleg aprosag, de igy keressuk a logokban mashol is.
rombow
approved these changes
Feb 21, 2024
czenczl
approved these changes
Mar 3, 2024
bucherarnold
approved these changes
Mar 4, 2024
vasizs
reviewed
Dec 2, 2024
| /** | ||
| * update all sampleEntity by params | ||
| * | ||
| * @param status status |
vasizs
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
delta spike @query annotation update example for:
i-Cell-Mobilsoft-Open-Source/coffee#597