Skip to content

Feature/96 coffee modify annotation examples #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sisak wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/96 coffee modify annotation examples #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b07af06
#96 coffee annotation changed
Feb 2, 2024
b59297c
#96 coffee annotation changed
Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...src/main/java/hu/icellmobilsoft/sampler/sample/jpaservice/action/JpaSamplePostAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ public SampleResponse sampleWriteRead(SampleRequest sampleRequest) throws BaseEx
throw new TechnicalException("Unexpected data integrity error, some mandatory field is empty or not equal!");
}

//set all entity to done
transactionHelper.executeWithTransaction(() -> {
sampleEntityService.updateAllStatusAndInputValue(SampleStatus.DONE, "done");
});

SampleResponse response = new SampleResponse();
response.setSample(sampleTypeConverter.convert(readed));

Expand Down
13 changes: 13 additions & 0 deletions ...n/java/hu/icellmobilsoft/sampler/sample/jpaservice/repository/SampleEntityRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
import jakarta.persistence.QueryHint;

import org.apache.deltaspike.data.api.EntityRepository;
import org.apache.deltaspike.data.api.Modifying;
import org.apache.deltaspike.data.api.Query;
import org.apache.deltaspike.data.api.QueryParam;
import org.apache.deltaspike.data.api.Repository;
import org.apache.deltaspike.data.api.criteria.CriteriaSupport;
import org.hibernate.jpa.HibernateHints;
Expand Down Expand Up @@ -74,4 +76,15 @@ public interface SampleEntityRepository extends EntityRepository<SampleEntity, S
// @Query(value = "SELECT s FROM SampleEntity s WHERE s.status = ?1")
List<SampleEntity> findAllByStatus(SampleStatus status);

/**
* update all sampleEntity by params
*
* @param status status
Copy link
Copy Markdown
Member

@vasizs vasizs Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formazas volt?

* @param inputValue input value
* @return status of update
*/
@Modifying
@Query("UPDATE SampleEntity s SET s.status = :status, s.inputValue = :inputValue")
int updateAllSampleStatusAndInputValue(@QueryParam("status") SampleStatus status, @QueryParam("inputValue") String inputValue);

}
21 changes: 21 additions & 0 deletions ...rc/main/java/hu/icellmobilsoft/sampler/sample/jpaservice/service/SampleEntityService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import hu.icellmobilsoft.coffee.dto.exception.BaseException;
import hu.icellmobilsoft.sampler.common.system.jpa.service.BaseService;
import hu.icellmobilsoft.sampler.model.sample.SampleEntity;
import hu.icellmobilsoft.sampler.model.sample.SampleEntity_;
import hu.icellmobilsoft.sampler.model.sample.enums.SampleStatus;
import hu.icellmobilsoft.sampler.sample.jpaservice.repository.SampleEntityRepository;

Expand Down Expand Up @@ -60,4 +61,24 @@ public class SampleEntityService extends BaseService<SampleEntity> {
public List<SampleEntity> findAllByStatus(SampleStatus status) throws BaseException {
return wrapListValidated(sampleEntityRepository::findAllByStatus, status, "findAllByStatus", "status");
}

/**
* Updates all SampleEntity entity with the given params
*
* @param sampleStatus new sampleStatus
* @param inputValue new inputValue
* @return status of update
* @throws BaseException on error
*/
public int updateAllStatusAndInputValue(SampleStatus sampleStatus, String inputValue) throws BaseException {

return wrapValidated(
sampleEntityRepository::updateAllSampleStatusAndInputValue,
sampleStatus,
inputValue,
"updateAllSampleStatusAndInputValue",
SampleEntity_.STATUS,
Copy link
Copy Markdown
Contributor

@rombow rombow Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*Service szinten nem szabad hogy legyen barmi rejtett logika, mindent az action szinten keresunk

Copy link
Copy Markdown
Author

@sisak sisak Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A SampleEntity_.STATUS ban csak az entity field neve van stringként generálva az entityből. Így változás biztos.
A két kódrészlet egyenlő:

 return wrapValidated(
                sampleEntityRepository::updateAllSampleStatusAndInputValue,
                sampleStatus,
                inputValue,
                "updateAllSampleStatusAndInputValue",
                "status",
                "inputValue"
        );

Copy link
Copy Markdown
Contributor

@rombow rombow Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapValidated parametereit eredetileg arra szantuk hogy a valos metodus valtozo neveit irja ki a logokban. Logikailag helyes ahogy irod, mivel a vegso mezo neve a entityben SampleEntity_.STATUS csak a metodusban az ehhez tartozo valtozo neve "sampleStatus". Ez most csak tenyleg aprosag, de igy keressuk a logokban mashol is.

SampleEntity_.INPUT_VALUE
);
}
}