Repository navigation
chore: drop unused deps, move openpyxl to an extra, disable dead metrics gate - #7
Merged
Merged
Conversation
…ics gate Three unrelated cleanup items from #4, all reversible/additive-metadata-only: 1. py2store was declared in [project] dependencies but is never imported anywhere in focal/ (only appears in README example fences) -- dropped. 2. openpyxl is a real (indirect, via pandas' xlsx engine) runtime need only for the optional xlsx codec path (extension_store.py's df_to_xlsx_bytes), so it belongs behind an extra rather than a hard dependency -- moved to a new [project.optional-dependencies] "excel" group, matching how numpy/pandas are already optional (lazy-imported under suppress(ModuleNotFoundError)). 3. [tool.wads.ci.metrics] was enabled=true pointing at .github/umpyre-config.yml, which does not exist -- a degraded no-op gate. Disabled, matching the same fix already applied in i2mint/git2py. Not done here (left open in #4, still the biggest "removes something" item): removing the 66 stale tracked docs/ files -- more visible/higher-blast-radius than the two dependency-metadata edits above, left for explicit maintainer sign-off as the issue itself flagged. No fleet dependents (fleet_dependents.json: focal -> []). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two of the three cleanup items from #4 (items 1 and 3 — the smallest-blast-radius ones; item 2, removing 66 stale tracked docs/ files, left for explicit maintainer sign-off as the issue itself flagged):
py2storewas declared in[project] dependenciesbut is never imported anywhere infocal/(only appears in a README example fence) — dropped.openpyxlmoved to an extra: it's a real (indirect, via pandas' xlsx engine) runtime need only for the optional xlsx codec path (extension_store.py'sdf_to_xlsx_bytes), so it belongs behind an extra rather than a hard dependency — moved to a newexceloptional-dependencies group, matching hownumpy/pandasare already optional (lazy-imported undersuppress(ModuleNotFoundError)).[tool.wads.ci.metrics]wasenabled = truepointing at.github/umpyre-config.yml, which doesn't exist — a degraded no-op. Disabled, matching the same fix already applied ini2mint/git2py.No fleet dependents (
fleet_dependents.json: focal -> []).Test plan
wads ci-local: 8 passed, format/lint/build all green (3.10 + 3.12) — including withpy2store/openpyxlabsent from the environment.gh pr checks --watchgreen before merge.🤖 Generated with Claude Code
https://claude.ai/code/session_011HSBVhDjRU4apSLcRkavv9