Repository navigation
fix: wrong-type list key is a TypeError; bytearray/memoryview stored as strings (#12) - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12.
del lst[i]/lst[i] = von a key holding a Redis string reportedIndexError. NowWRONGTYPE->TypeError(key untouched); 'no such key' / 'index out of range' stayIndexError; otherResponseErrors (READONLY, OOM...) are no longer disguised and propagate unchanged.RedisPersister[k] = bytearray/memoryviewwas stored as a list of ints; now a string (bytes(v)).Adversarial review (Opus): goals met on fakeredis/redis-py (RESP2/3, decode_responses). Confirmed and fixed: the classifier read the key's name out of a pipeline's quoted command (a key named
WRONGTYPEturned an IndexError into TypeError; a READONLY on a key namedno such keybecame IndexError), and pass-through errors became their own__cause__; now only the server's words are classified and a bareraisere-raises. Out of scope, filed: other list operations on wrong-type keys still leak raw errors; bytes-like list elements.🤖 Generated with Claude Code