Repository navigation
Missing keys raise KeyError; _convert_numeric_list passes non-lists through - #9
Merged
Merged
Conversation
…nsupported redis types Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Adversarial review (fresh Opus subagent): sound for #4/#5, two confirmed gaps, both fixed in the last commit: (1) hash/set/etc keys returned None -> now TypeError naming the redis type (loud, like RedisBytesPersister); (2) with decode_responses=True the type string is text, so every key returned None -> type is normalised. Both have tests (17 pass). Out of scope, tracked: RedisList IndexError (#7); store_from_source(r, RedisStoreWithNumericLists) AttributeError ('store') -> new issue. Dependents gate: priv test-dependents redisdol --transitive finds no dependents with suites (py2store only re-exports via import *). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4, fixes #5.
RedisBytesCollection/Reader/RedisCollection.__getitem__raiseKeyErrorfor absent keys (sostore.get(k, default)works). Behaviour change: callers that relied onNonemust now catch KeyError / use.get._convert_numeric_listreturnsdataunchanged for non-lists (string values no longer come back as None,dict(store)works). Documented that the numeric-lists store returns a detached snapshot list.Review and dependents-gate notes to follow in a comment before merge.