Skip to content

[Sprint 22 / PD-369] - [Feature] Create gRPC-web Client on Akushon App#24

Open
FaaizHaikal wants to merge 43 commits into
masterfrom
feature/using-grpc
Open

[Sprint 22 / PD-369] - [Feature] Create gRPC-web Client on Akushon App#24
FaaizHaikal wants to merge 43 commits into
masterfrom
feature/using-grpc

Conversation

@FaaizHaikal
Copy link
Copy Markdown

@FaaizHaikal FaaizHaikal commented Oct 30, 2023

Jira Link

https://ichiro-its.atlassian.net/browse/PD-369

Description

Previously, we used the Kumo-app as a communication bridge between Akushon and Akushon-app. However, this feature has proven to be unreliable due to its enormous latency.

The following changes are included in this pull request:

  • We are now using gRPC-web and an Envoy proxy for communication with the Akushon server.
  • New button for deleting pose
  • New button to add new action
  • Fixed bugs such as typecasting, JSON parsing, etc.

The gRPC and gRPC-web methods have significantly improved latency, reducing it to around 20-30ms for their services.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

Screenshots

UI Changes

BEFORE

image

AFTER

Screenshot from 2023-10-30 20-08-41

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

Comment thread .env Outdated
Comment thread envoy.yaml Outdated
Comment thread src/components/ActionManager.jsx Outdated
Comment thread src/components/ActionManager.jsx Outdated
Comment thread src/components/ActionManager.jsx Outdated
Comment thread src/components/GetActionsButton.jsx Outdated
Comment thread src/components/RunActionButton.jsx Outdated
Comment thread src/components/SetTorquesButton.jsx Outdated
@JayantiTA
Copy link
Copy Markdown
Member

Good UI 👍🏻

@FaaizHaikal FaaizHaikal requested a review from JayantiTA October 31, 2023 07:13
Comment thread src/components/SetJointsButton.jsx Outdated
Comment thread src/components/SetTorquesButton.jsx Outdated
Comment thread .eslintrc.js
@FaaizHaikal FaaizHaikal requested a review from threeal May 31, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants