Increase val-2f/val-2c reproducibility - #385

Merged

simopier merged 78 commits into

idaholab:develfrom

lindsayad:try-some-regularization

Apr 10, 2026

Commits on Mar 20, 2026

Fix light tests

lin-yang-ly
authored and
loganharbour
committed
9141968
update val-2f HPC and local MacOS mismatch

lin-yang-ly
authored and
loganharbour
committed
54f0f4a
update petsc hyperparameters to solve the multi-cores mismatch

lin-yang-ly
authored and
loganharbour
committed
01adb18
update for multi-cores runs on HPC

lin-yang-ly
authored and
loganharbour
committed
745ddf4
avoid recover issue in this PR

lin-yang-ly
authored and
loganharbour
committed
562d5c3
update val-2c_immediate_injection_exodus for failure with 2 threads

lin-yang-ly
authored and
loganharbour
committed
3ad6b55
solve the multi-core issue for yttrium_hydrogen_system

lin-yang-ly
authored and
loganharbour
committed
303045c
keep multi-core issue of val-2f for future

lin-yang-ly
authored and
loganharbour
committed
8780a32
MacOS faulure of heavy tests will be solved in another PR

lin-yang-ly
authored and
loganharbour
committed
a1b7fee
move val-2f parameters to test file

lin-yang-ly
authored and
loganharbour
committed
9151669
leave the recover issue and val-2f multi-core issue for now

lin-yang-ly
authored and
loganharbour
committed
5cbba6d
Apply suggestions from code review

authored and
loganharbour
committed
7d0c2f3
update test checks for solved recover and multi-core issue

lin-yang-ly
authored and
loganharbour
committed
150c67d
update documentation

lin-yang-ly
authored and
loganharbour
committed
3a765b6
solve one recover failure for yttrium_hydrogen_system

lin-yang-ly
authored and
loganharbour
committed
484f9a9
ignore recover issue due to current PR focusing on OS and multi-core issue

lin-yang-ly
authored and
loganharbour
committed
9dae4e6
Update moose submodule
loganharbour
committed
b0bf4d0

Commits on Mar 23, 2026

solve failure for val-2c_delay_csv with moose update
lin-yang-ly
committed
0f0c001
Nondimensionalize val-2f
lindsayad
committed
1f0a889
Remove nondimensionalization doc
lindsayad
committed
bf6bf19
Simplify dimensionless physics/kernel logic
lindsayad
committed
b45e478
Clarify trapping_prefactor
lindsayad
committed
a1c5994
Robustify physics exception testing after parameter check reordering in code
lindsayad
committed
f01815d
Ignore temporary testharness_time files
lindsayad
committed
2d7ecdb
Skip dimensional val-2f
lindsayad
committed
95aa871

Commits on Mar 24, 2026

Remove extraneous exodus output from csv test
lindsayad
committed
f2bbd02
Bump abs_tol back up for val-2c delay test
lindsayad
committed
1a8f9d5
Set bounds to 0 not negative
lindsayad
committed
665e9dc
Add some postprocessors for viewing concentration magnitudes
lindsayad
committed
18bc8ae
val-2c delay robustness upgrades
lindsayad
committed
cd15982
Regold other tests
lindsayad
committed
1957cf5
Remove parallel restriction from stochastic tools test
lindsayad
committed
b89dcb1
Remove cruft
lindsayad
committed
ca29026
Add component-physics example of shared-occupancy use of TrappingNodalKernelDimensionless
lindsayad
committed
cb243bf

Commits on Mar 25, 2026

Revert changes made to val-2f tests spec
lindsayad
committed
18f8087
Add parameters for nondimensionalization val-2f params
lindsayad
committed
ec189d5

Commits on Mar 26, 2026

make val-2f dimensionless
lindsayad
committed
2f1e06b
Remove dimensionless directory
lindsayad
committed
7549dde

Commits on Mar 27, 2026

bump tolerances more
lindsayad
committed
167df2a
Add more sensible testing of the heavy val-2f cases
lindsayad
committed
8d41469
Ask user what conda env is
lindsayad
committed
2c3ef8b
Remove redundant FactoredCoupledTimeDerivative
lindsayad
committed
56f55d2
Add missing doc pages
lindsayad
committed
c4a7f74
Ignore checkpoint directories
lindsayad
committed
d997bd4
Normalize recent non-ASCII text

lindsayad
and
claude
committed
6a4086e
Remove reverted scaling references

lindsayad
and
claude
committed
af29870
Revert unnecessary changes related to variable scaling in SpeciesTrappingPhysics
lindsayad
committed
d0d473f
Fix ReleasingNodalKernelDimesionless doxygen
lindsayad
committed
d17213f
Remove unused timeReference
lindsayad
committed
e8a6758
Remove unnecessary scripts
lindsayad
committed
ea81512
Cosmetic changes to residual return in dimensionless kernels
lindsayad
committed
09e7cdf
Change MooseIndex to make_range
lindsayad
committed
72cd0b0
Further reduce SpeciesTrappingPhysics diff
lindsayad
committed
8fb26e4
Reduce code duplication by creating releasing/trapping nodal kernel base classes
lindsayad
committed
939966b
Clean up val-2f params file
lindsayad
committed
c80aa68
Add missing doxygen
lindsayad
committed
fd24053
Remove extraneous diff in val-2f.i
lindsayad
committed
2c0e137
Remove yttrium tests that aren't adding any value
lindsayad
committed
aba9b3c
Allow brittle yttrium tests to run in recover mode
lindsayad
committed
9d47079
Switch val-2f RMSPE tests over to RecoverableRunCommand
lindsayad
committed
67ab91b

Commits on Apr 4, 2026

Apply suggestions from code review: round 1 with maximum of 50

lin-yang-ly
and
simopier
authored
f4b52c8
Apply suggestions from code review: round 2

lin-yang-ly
and
simopier
authored
5422deb

Commits on Apr 6, 2026

quick test only for val-2c
lin-yang-ly
committed
e28b7c8
quick test only for val-2c: update formats
lin-yang-ly
committed
45fa6e0
fix physics test case
lin-yang-ly
committed
ab9e876

Commits on Apr 7, 2026

Apply suggestions from code review

lin-yang-ly
and
simopier
authored
4ef6a28
revert YHx tests
lin-yang-ly
committed
3fdbb02
quick test for val-2f:light case
lin-yang-ly
committed
25d0d83
quick tests for val-2f:heavy
lin-yang-ly
committed
fa79738
update YHx failure tests
lin-yang-ly
committed
400bbb3
update val-2f-heavy tests
lin-yang-ly
committed
df7679f
Add the two versions of accuracy for val-2c and val-2f
lin-yang-ly
committed
9a3a2f5

Commits on Apr 8, 2026

Apply suggestions from code review

lin-yang-ly
and
simopier
authored
6699bcf

Commits on Apr 9, 2026

Add val-2c bdf2 tests: quick test
lin-yang-ly
committed
991b650
val-2f heavy tests: including both schemes quick test
lin-yang-ly
committed
28fa0d7
update submodule
lin-yang-ly
committed
06b6e92
update heavy tests rel_err
lin-yang-ly
committed
4a7917a

Commits on Apr 10, 2026

Apply suggestions from code review

lin-yang-ly
and
simopier
authored
d6906cb