docs: clarify QuickNodeWebhookService checkpoint-advance comment - #260
Merged
Conversation
The "always advance checkpoint" comment didn't mention the one case where that's not true: when no SolanaChainReader is configured, processPayload() returns early and the checkpoint stays put — intentional (lets a later-configured reader recover the slot instead of skipping past it), and already covered by QuickNodeWebhookServiceTest. No behavior change. Signed-off-by: ifsantana <flaubert165@gmail.com>
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QuickNodeWebhookService.kt— the "always advance checkpoint" comment didn't call out that it's scoped to the case where aSolanaChainReaderis available. No production logic change.Closes #257
Test plan
./mvnw test -pl infrastructure -Dtest=QuickNodeWebhookServiceTest— 26/26 passing, unchanged