Skip to content

docs: clarify QuickNodeWebhookService checkpoint-advance comment #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifsantana merged 2 commits into from
Aug 14, 2026
Merged

docs: clarify QuickNodeWebhookService checkpoint-advance comment #260

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a506d92
docs: clarify QuickNodeWebhookService checkpoint-advance comment (#257)
ifsantana Aug 14, 2026
e157a89
Merge branch 'main' into docs/quicknode-checkpoint-comment-257
ifsantana Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion infrastructure/src/main/kotlin/finance/idem/infrastructure/chain/QuickNodeWebhookService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ class QuickNodeWebhookService(
}
}

// Always advance checkpoint regardless of whether any transfer matched.
// Always advance checkpoint regardless of whether any transfer matched — but only
// once a SolanaChainReader is available to verify the slot (see the reader != null
// check above; without a reader this method returns early and the checkpoint stays put).
// Prevents SolanaChainReader from re-scanning already-delivered slots on restart.
val newCheckpoint = maxOf(existingCheckpoint, payload.slot)
if (newCheckpoint > existingCheckpoint) {
Expand Down