Add split-device text encoder routing - #38
Draft
Dillflix wants to merge 12 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text_devicerouting while retainingdeviceas the diffusion-device API and aliasMotivation
The existing single-device pipeline loads Qwen3-VL alongside both diffusion transformers and the VAE. On memory-constrained diffusion GPUs, Qwen's one-time forward pass can exhaust the remaining VRAM before sampling begins. Keeping Qwen on a secondary GPU frees diffusion-device headroom while avoiding cross-device traffic inside the denoising loop.
Existing callers that omit
text_deviceretain the original single-device behavior.Validation
Hardware validation status
The development host available for this patch is Windows with CPU-only PyTorch (
HIP=None, zero visible GPUs), so model-weight and ROCm hardware validation has not been run here. The included smoke script performs device preflight, reports peer access and peak memory, accepts local structured captions, and supports the officialV4_DEFAULT_20preset for the target 1024x1024 acceptance run.ROCm multi-GPU support is documented as experimental. The main remaining validation risks are bitsandbytes NF4 support across both gfx1100 and gfx1151 and any shape-dependent numerical differences from trimming trailing image placeholders.