Skip to content

[BUG] Stop HTTP links that fail HTTPS upgrade from crashing - #25

Merged
ignaciojuarez merged 1 commit into
mainfrom
fix/https-first-interstitial
Nov 15, 2026
Merged

ignaciojuarez merged 1 commit into
mainfrom
fix/https-first-interstitial

Conversation

@ignaciojuarez

Copy link
Copy Markdown
Owner

Opening an http:// link whose HTTPS upgrade fails crashed the host app.

Chromium 157 shows HTTPS-First fallbacks in a tab-modal Ask-before-HTTP dialog. Host-owned windows have no Chrome widget to anchor it, so TabDialogManager::CreateTabScopedDialog CHECK-failed (CHECK(host)) on the browser main thread.

  • New patch 0041-show-https-first-interstitial.patch: in Cobble mode the upgrades throttle uses Chromium's full-page HTTPS-First interstitial instead of the dialog, and HttpsOnlyModeTabHelper no longer tries to show the dialog.
  • Source test checks both gates.

Verified:

  • Crash report from a beta 16 runtime, symbolicated with the matching dSYM: AskBeforeHttpDialogController::ShowDialog → TabDialogManager::CreateTabScopedDialog.
  • Python source tests pass. Incremental native rebuild and package passed (cobble-sdk-157.0.8103.39-arm64-2d09b63a67b3-027d29ed5bd9), and so did scripts/smoke.mjs.
  • A Full Cobble build with this runtime opened the failing http:// host in a Chromium tab, showed the interstitial without crashing, and loaded the site after Continue.

No ABI change.

🤖 Generated with Claude Code

Chromium 157 shows HTTPS-First fallbacks in a tab-modal Ask-before-HTTP
dialog. Host-owned Cobble windows have no Chrome widget to anchor it, so
TabDialogManager CHECK-failed. Use the full-page interstitial instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ignaciojuarez
ignaciojuarez merged commit 9c773eb into main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant