[codex] Fix Browser plugin file URL policy#306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://targets are allowed on Linux.data:,javascript:,ftp:, invalid URLs, and remotefile://host/...URLs stay blocked.try { new URL(...) } catch { return false }helper shape.Fixes #268.
Root cause
The bundled Browser plugin advertises local
file://support, and the downstream approval flow already knows how to request approval forfile:origins. The earlier URL policy gate rejectedfile:before that approval path could run.Validation
bash -n scripts/lib/bundled-plugins.sh tests/scripts_smoke.shgit diff --checktests/scripts_smoke.shmake build-app-freshagainst freshly downloaded upstream DMG26.519.41501/ Electron42.1.0/ SHA2563101c05dfd40314115418c4ad87edee02419d097f7164c677ddbdd4559ad8a42codexLinuxFileUrlPolicyin the real upstream helper and no URL-policy insertion warning is emitted